mmazzarolo / react-native-dialog

Pure JavaScript React-Native dialog
MIT License
681 stars 111 forks source link

The Dialog.Title disappears on android with dark mode ON #156

Open nimeshmaharjan1 opened 5 months ago

nimeshmaharjan1 commented 5 months ago

Platforms

Only on Android

Versions

Reproducible Demo

change the appearance to dark mode

   <Dialog.Container
                    onBackdropPress={() => setShowDeleteDialog(false)}
                    visible={showDeleteDialog}
                  >
                    <Dialog.Title>Delete Request</Dialog.Title>
                    <Dialog.Description>
                      Are you sure you want to delete this material request?
                    </Dialog.Description>
                    <Dialog.Button
                      onPress={() => setShowDeleteDialog(false)}
                      label="Cancel"
                    ></Dialog.Button>
                    <Dialog.Button
                      onPress={() =>
                        deleteMutation.mutate(query.data.payload.id)
                      }
                      label="Delete"
                    ></Dialog.Button>
                  </Dialog.Container>
WeeJeWel commented 5 months ago

+1, but also happens without dark mode in my simulator.

Screenshot 2024-04-05 at 19 40 44
barrettpyke commented 3 months ago

You can resolve this by applying color directly to the title like... <Dialog.Title style={Platform.OS === 'android' ? { color: 'black' } : {}}>Test Input</Dialog.Title>

EDIT: Same thing happens with Dialog.Input text and can be resolved by same styling as above

andreasbroch2 commented 2 weeks ago

+1. The applying color directly works fine though.