`DeviceEventEmitter.removeListener` is not supported on React Native 0.70+

[fansilva1991]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-modal-datetime-picker@9.2.3 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-modal-datetime-picker/src/Modal.js b/node_modules/react-native-modal-datetime-picker/src/Modal.js
index 6e5f95d..1466d08 100644
--- a/node_modules/react-native-modal-datetime-picker/src/Modal.js
+++ b/node_modules/react-native-modal-datetime-picker/src/Modal.js
@@ -48,10 +48,12 @@ export class Modal extends Component {
   }

   componentWillUnmount() {
-    DeviceEventEmitter.removeListener(
-      "didUpdateDimensions",
-      this.handleDimensionsUpdate
-    );
+    try {
+      DeviceEventEmitter.removeListener(
+        "didUpdateDimensions",
+        this.handleDimensionsUpdate
+      );
+    } catch (e) {} 
     this._isMounted = false;
   }

This issue body was partially generated by patch-package.

[fansilva1991]

Looks like this is happening because DeviceEventEmitter.removeListener has been removed after being deprecated for a while.

[mmazzarolo]

👋 I think a good starting point would be to use https://github.com/mmazzarolo/react-native-modal-datetime-picker/pull/669 and support the new device dimension update API instead

[joe-brabben]

@mmazzarolo Hi any updates on this being landed as it is currently crashing devices. Thanks

[mmazzarolo]

Hey I'm currently on parental leave and can't work directly on the codebase. If you're willing to update #669 adding support for the updated Dimensions API I can give it a review and try it out.

[joe-brabben]

@mmazzarolo Hey sorry for the delay was busy on new native version for a bit. I've submitted the pull request now so should all be good. Thanks

[khzouroussama]

@fansilva1991 this will be fixed if you update the library, there is no need for this patch, the deprecated API DeviceEventEmitter.removeListener has been already replaced with listener.remove()

@mmazzarolo I don't think we need to do any changes here

[mmazzarolo]

@khzouroussama not sure I'm following, who replaced DeviceEventEmitter.removeListener with listener.remove()? 👀 It's still here in this lib.

[khzouroussama]

I believe it was changed here https://github.com/mmazzarolo/react-native-modal-datetime-picker/pull/591 I was facing the same issue before because my app was on an older version, so it is not reproducible on the recent versions

[mmazzarolo]

Ah, right, I thought this issue was about something different. Good call, thanks!

[joe-brabben]

@mmazzarolo sounds fixed. Want me to close the pull request???