search

mmazzarolo / react-native-modal-datetime-picker

A React-Native datetime-picker for Android and iOS
MIT License
2.98k stars 399 forks source link

Swap styles in CancelButton (ios) #689

Closed madly0894 closed 1 year ago

madly0894 commented 1 year ago

Hi. I have a problem with custom styles customCancelButtonIOS. I can't style the backgroundColor because the passed style comes first. You are correct put style for the ConfirmButton but not for the CancelButton. You correctly marked the places in the 1st picture. But in the 2nd photo he does not see him, because he goes first. Would you please switch places for CancelButton?

// Confirm button image

// Cancel button Screenshot from 2023-01-26 19-29-31

mmazzarolo commented 1 year ago

Ha! Good catch. Mind submitting a PR to fix it?

madly0894 commented 1 year ago

Ha! Good catch. Mind submitting a PR to fix it?

Yes, I think. It's not worth writing your own component just because of one problem. This component would give us the ability to style it. Otherwise, hardcoding turns out.

mucahittceylann commented 1 year ago

same problem, is it resolved

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 17.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: