mmazzarolo / react-native-modal-datetime-picker

A React-Native datetime-picker for Android and iOS
MIT License
2.98k stars 399 forks source link

`onCancel` type includes `date` parameter #709

Closed robert-nash closed 1 year ago

robert-nash commented 1 year ago

The typings currently include a date parameter for the onCancel function. As far as I can tell this is not correct? I don't think this would ordinarily cause much of an issue but I am trying to create a component which implements ReactNativeModalDateTimePickerProps for use on web which has brought it to the fore.

https://github.com/mmazzarolo/react-native-modal-datetime-picker/blob/4aee8ae499d4dec2989ca8cf38462de06f18c295/typings/index.d.ts#L274

mmazzarolo commented 1 year ago

Yep looks like a bug mind submitting a PR?