search

mmazzarolo / react-native-modal-datetime-picker

A React-Native datetime-picker for Android and iOS
MIT License
2.98k stars 399 forks source link

Support iPhone 14 Pro & Pro Max safe area bottom inset #718

Closed kolking closed 1 year ago

kolking commented 1 year ago

Overview

- Added missing iPhone 14 Pro & iPhone 14 Pro Max dimensions to the `isIphoneX()` method. - The `marginBottom` is applied to `modal` styles rather than the cancel button styles. This allows overriding the bottom margin through `modalStyleIOS`. - The margin value is updated to `34pt` which is the proper size of the iOS bottom inset. Reference: [iPhone 14 Screen Sizes](https://useyourloaf.com/blog/iphone-14-screen-sizes/) # Test Plan

The bottom inset of 34pt should appear for iPhone 14 Pro and iPhone 14 Pro Max. Users should be able to manually update the inset value through modalStyleIOS prop.

mmazzarolo commented 1 year ago

Hey @kolking , thanks, this makes sense sense to me 👍

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 17.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: