mmazzarolo / react-native-modal-datetime-picker

A React-Native datetime-picker for Android and iOS
MIT License
2.96k stars 396 forks source link

isDarkModeEnabled doesn't work on spinner in iOS #749

Open darshan-palm opened 4 months ago

darshan-palm commented 4 months ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

The prop "isDarkModeEnabled" doesn't have an effect on the internal Picker theme in iOS. Here is the diff that solved my problem:

diff --git a/node_modules/react-native-modal-datetime-picker/src/DateTimePickerModal.ios.js b/node_modules/react-native-modal-datetime-picker/src/DateTimePickerModal.ios.js
index 6ef0b0a..89a5bb6 100644
--- a/node_modules/react-native-modal-datetime-picker/src/DateTimePickerModal.ios.js
+++ b/node_modules/react-native-modal-datetime-picker/src/DateTimePickerModal.ios.js
@@ -178,6 +178,7 @@ export class DateTimePickerModal extends React.PureComponent {
               display={display || "spinner"}
               {...otherProps}
               value={this.state.currentDate}
+              themeVariant={_isDarkModeEnabled ? 'dark' : 'light'}
               onChange={this.handleChange}
               // Recent versions @react-native-community/datetimepicker (at least starting with 6.7.0)
               // have a peculiar iOS behaviour where sometimes, for example in react-native Modal,
nehresma commented 1 week ago

Thanks for the pointer on this @darshan-palm. I've submitted a slightly modified PR that only sets this when not using the customPickerIOS prop.