feat: add tvos and android tv

thefinnomenon commented 2 years ago

This PR adds support for tvOS and Android TV.

Here are the dev notes, https://unequaled-ray-da9.notion.site/Add-TV-Support-8e62afc3d02b408489ed0b4f7d6a97a6

I'm going to turn it into a blog post tomorrow if that's fine with you.

Also, thanks for answering my issue so quick. Your advice was super helpful and I'm going to try to add Next next.

mmazzarolo commented 2 years ago

Woah! I'm AFK now and I can't test it but this looks phenomenal. Great work 🙌 I should be able to give it a try on Tue/Wed.
And yeah, definitely go for a blog post. I'll gladly link it too 👍

thefinnomenon commented 2 years ago

Cool cool! Here is the blog post, https://finnternet.com/dev/blog/react-native-tv-monorepo.

The only two kinda weird things are,

I set the CRA projects to skip the preflight checks because they were complaining about a version of Jest with a higher patch version being hoisted. I figured that was the easiest solution but if you want you could either nohoist Jest or I guess pin the specific version on those packages.
For the TV types in the app project I dynamically import them based on if the platform is TV or not but in order to avoid static analysis errors for non-TV platforms, I had to wrap it in an eval which seems rather hacky but works.

Also, I am working on Next support and can open a PR after if you are cool with that.

thefinnomenon commented 2 years ago

Everything should be good! The only thing left is how you want to handle the tv types import. I am importing it in app config.js so the extra types are always available, but let me know what you think.

thefinnomenon commented 2 years ago

Should be all set 👍🏽

mmazzarolo / react-native-universal-monorepo

feat: add tvos and android tv #15