search

mmazzarolo / react-native-universal-monorepo

React Native boilerplate supporting multiple platforms: Android, iOS, macOS, Windows, web, browser extensions, Electron.
MIT License
1.7k stars 150 forks source link

Fix build/script script names in electron #35

Open whenmoon opened 2 years ago

whenmoon commented 2 years ago

When I run yarn electron:package:mac I get the error "Command "build" not found". When I update the packages/electron package.json script to remove yarn build from the "package:mac" script, electron build throws the error: "Application entry file "build/electron.js in Contents/Resources/app.asar" does not exist".

Is there a way to resolve this? Thanks.

whenmoon commented 2 years ago

Ok solved the latter issue by running the cra:build script first.

mmazzarolo commented 2 years ago

Ha! @whenmoon this is actually a bug, good call — these two commands should probably drop the cra: prefix.

whenmoon commented 2 years ago

Hi @mmazzarolo, ok , I'll open a PR to fix..

WayneKim92 commented 2 years ago

Remove cra: prefix and then remevoe ^ at devDependencies of electron. like that ^14.0.0 -> 14.0.0

code4break commented 2 years ago

In my opinion, this issue can be closed.