search

mmbell / samurai

Spline Analysis at Mesoscale Utilizing Radar and Aircraft Instrumentation
GNU General Public License v3.0
13 stars 17 forks source link

Fixed a major memory leak and performance problem. #10

Closed johnmauff closed 7 months ago

johnmauff commented 7 months ago

An allocation of two 64-bit int within a loop in the CostFunction3D:obAdjustments() method was causing a massive memory leak and performance problems. In particular, the supercell case was killed after several hours of run time on the GPU after exceeding 400GB of CPU main memory usage. An old version of Samurai only took 36GB and ~15 minutes of total runtime. Note that several comments were intentionally left within the code to allow further group discussion.

johnmauff commented 7 months ago

Thanks for taking a look at the bug fix so quickly.

tingyucha commented 7 months ago

Thanks so much for fixing the memory leak!! The fix looks good to me! I was just doing some tests and trying to understand the code back then! Thanks!

johnmauff commented 7 months ago

Great, I will merge the pull request then.

johnmauff commented 7 months ago

Address a memory leak and performance problem.