Closed johnmauff closed 7 months ago
Thanks for taking a look at the bug fix so quickly.
Thanks so much for fixing the memory leak!! The fix looks good to me! I was just doing some tests and trying to understand the code back then! Thanks!
Great, I will merge the pull request then.
Address a memory leak and performance problem.
An allocation of two 64-bit int within a loop in the CostFunction3D:obAdjustments() method was causing a massive memory leak and performance problems. In particular, the supercell case was killed after several hours of run time on the GPU after exceeding 400GB of CPU main memory usage. An old version of Samurai only took 36GB and ~15 minutes of total runtime. Note that several comments were intentionally left within the code to allow further group discussion.