search

mmbell / samurai

Spline Analysis at Mesoscale Utilizing Radar and Aircraft Instrumentation
GNU General Public License v3.0
13 stars 16 forks source link

Data type additions #14

Closed mmbell closed 4 months ago

mmbell commented 4 months ago

This PR adds two new data types, renames one type, and removes some debugging messages.

The new data types are NOAA HRD thinned Doppler radials that are sent off the P3 aircraft in real-time with the suffix .list, and HDOBS in situ data format produced by both NOAA and USAF aircraft with the suffix .hdob.

The 'model' data type previously had a suffix of .txt, but this caused some confusion and user errors since the suffix was not descriptive enough and is frequently used with files that are not in the prescribed format. The suffix has been changed to .model which is not commonly in use and is more descriptive. Samurai will now ignore .txt files rather than try to read them in.

Some debugging messages that printed on loop when loading a background file were removed.

A commit to match up the CMakeLists.txt file with the current master version that has been approved in multiple recent PRs was also added in order to avoid conflicts and enable a seamless merge of this branch.

johnmauff commented 4 months ago

@mmbell This PR is missing a number of changes made by myself and Jian that were made weeks ago which prevents me from easily verifying that the code actually runs correctly on both CPU and GPU. I am guessing that you did not update your hrd_radius branch with commits from the master. Could you do this? Otherwise, all of the changes that Jian and myself have made will be overwritten.

mmbell commented 4 months ago

@johnmauff You were correct. I thought that the PR would only affect the files I modified, but I was behind on master. I added two commits to update my local master and merge it in with hrd_radials. The history now looks accurate to me and has all of your's and Jian's commits. Please review that I did it correctly and then we can merge it. Thanks!

mmbell commented 4 months ago

All changes reviewed and accepted.