Open cenamiller opened 3 months ago
set param output_txt=TRUE u,v,w,vorticity, divergence in samurai_XYZ_analysis.out? Need to check meaning of different output files (analysis/increment/background).
Add residual check as super basic check in meantime - can also be used for other test cases besides Beltrami
Currently code produces a residual number and prints out the number of iterations to solve. This number would be different for each test case. Supreeth currently has a python script that does this for Beltrami - need to find and add to CI workflow. Supreeth will add to CI workflow.
From Supeeth (Thanks!)
The validation script /glade/work/ssuresh/apar/samurai_validation/ is here in this directory.
Example usage: Usage: python validation.py refernce_log_file run_log_file
Supreeth will send docker file need to rebuild it, and add something like 'python validation.py log1 log2' to the end Don't need to change workflow yaml
in dockerfile, need to pipe output of ./samurai -params /app/samurai/ncar_scripts/TDRP/beltrami.tdrp\ " > /app/run_samurai.sh to specific file name to be used
John will supply reference file
We need to integrate a check of these variables for the small (16kmx16km) Beltrami case: RMSE U V W Vorticity Divergence Small 0.03396 0.03396 0.03957 7.132e-5, 8.618e-5 Medium 0.03284 0.03284 0.04014 4.441e-5 4.477e-5 Large 0.03265 0.03265 0.04025 3.796e-5 3.256e-5
This check will be included in the CI pipeline, so that we can be confident our optimizations aren't producing bad results. NOTE: The Beltrami case is not an end-to-end test of the workflow and doesn't cover input/preprocessing or (of course) the RadarQC code