According to the test PR here (https://github.com/mmbell/samurai/pull/49), the CI workflow is not set up correctly as I removed the CMakeLists.txt file but the test still passes.
The root cause is that in the Dockerfile, we always clone the SAMURAI code (https://github.com/mmbell/samurai/blob/main/Dockerfile#L11) first. In this way, we are actually testing the current main branch rather than the code changes in the PR.
According to the test PR here (https://github.com/mmbell/samurai/pull/49), the CI workflow is not set up correctly as I removed the
CMakeLists.txt
file but the test still passes.The root cause is that in the
Dockerfile
, we always clone the SAMURAI code (https://github.com/mmbell/samurai/blob/main/Dockerfile#L11) first. In this way, we are actually testing the currentmain
branch rather than the code changes in the PR.