search

mmbell / samurai

Spline Analysis at Mesoscale Utilizing Radar and Aircraft Instrumentation
GNU General Public License v3.0
13 stars 16 forks source link

Cleanup magic 7's and other dimension issues. #87

Closed cenamiller closed 3 weeks ago

cenamiller commented 1 month ago

There are a lot of '7's floating around the code. Sometimes refer to

  1. number of variables
  2. size of meta data
  3. indexing

Need to consolidate to global variables for 1 and 2 points

May require a little extra work to get these variables accessible throughout code?

cenamiller commented 1 month ago

This is a top priority because it's required for the control code to work for the 'thermo' mode

cenamiller commented 1 month ago

John will do a commit where the variables currently need to be set in 2 locations - Supreeth is going to try to get that down to one global location. These values should be set in the parameter file, instead of being hard coded.

Our goal is to not need to recompile between wind and thermo runs - there should be one executable that takes the mode as a parameter

cenamiller commented 1 month ago

John will create a feature branch with his code progress. @johnmauff

johnmauff commented 4 weeks ago

PR #94 was created that partially addresses this issue

cenamiller commented 3 weeks ago

Kamino cloned this issue to NCAR/samurai-dev

cenamiller commented 3 weeks ago

Closed with PR #94