Closed cenamiller closed 2 months ago
Developed here: /glade/derecho/scratch/cmille73/APAR/issue84_calcA/samurai
Attention: Patch coverage is 4.57143%
with 167 lines
in your changes missing coverage. Please review.
Project coverage is 32.83%. Comparing base (
be74897
) to head (988d18e
). Report is 4 commits behind head on thermo_asap.
Files | Patch % | Lines |
---|---|---|
src/VarDriver.cpp | 4.57% | 167 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good. Thanks for getting the CI/CD workflow in the thermo_asap branch.
Includes calc_A_thermo(), calc_B_thermo(), calc_C_thermo(), calc_D_thermo(), calc_E_thermo(), getValue_thermo(), and getDerivative_thermo(). Builds and runs without QT - But this code will need to be thoroughly tested with a thermo run!!
Needs thermo control flow variable in the VarDriver constructor and destructor. Includes a variable f_thermo that in initialized in VarDriver() but comments indicate it should be moved to parameter file to be set dynamically in the future