search

mmbell / samurai

Spline Analysis at Mesoscale Utilizing Radar and Aircraft Instrumentation
GNU General Public License v3.0
13 stars 17 forks source link

Pr issue84 #90

Closed cenamiller closed 2 months ago

cenamiller commented 2 months ago

Includes calc_A_thermo(), calc_B_thermo(), calc_C_thermo(), calc_D_thermo(), calc_E_thermo(), getValue_thermo(), and getDerivative_thermo(). Builds and runs without QT - But this code will need to be thoroughly tested with a thermo run!!

Needs thermo control flow variable in the VarDriver constructor and destructor. Includes a variable f_thermo that in initialized in VarDriver() but comments indicate it should be moved to parameter file to be set dynamically in the future

cenamiller commented 2 months ago

Developed here: /glade/derecho/scratch/cmille73/APAR/issue84_calcA/samurai

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 4.57143% with 167 lines in your changes missing coverage. Please review.

Project coverage is 32.83%. Comparing base (be74897) to head (988d18e). Report is 4 commits behind head on thermo_asap.

Files Patch % Lines
src/VarDriver.cpp 4.57% 167 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## thermo_asap #90 +/- ## =============================================== + Coverage 32.49% 32.83% +0.34% =============================================== Files 51 51 Lines 16947 17287 +340 =============================================== + Hits 5507 5677 +170 - Misses 11440 11610 +170 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

johnmauff commented 2 months ago

Looks good. Thanks for getting the CI/CD workflow in the thermo_asap branch.