search

mmcardle / django_builder

Django Builder Site
MIT License
608 stars 126 forks source link

Minor improvement to template 'extends'? #63

Open darkpixel opened 5 years ago

darkpixel commented 5 years ago

https://github.com/mmcardle/django_builder/blob/cd855f7edeb41f62e9e6af692a6eb1fb57509ec1/app/js/services.js#L1035

I think this should generate {% extends "appname/base.html" %} so each app can have it's own base template. In a lot of apps, appname/base.html simply extends base.html, but in several cases apps append or prepend stuff to {% block content %} or include javascript, etc...

mmcardle commented 5 years ago

That sounds sensible, will take a look. I think in order for the download to function straight out of the box, we would need to add a base.html file and an appname/base.html file to the tar file.