search

mmcc-xx / WhosAtMyFeeder

316 stars 15 forks source link

Add code quality tooling and fix suggestions it gives #19

Closed bertybuttface closed 1 year ago

bertybuttface commented 1 year ago

I've added a Github action to run black, isort and autoflake. Once it has done so it commits the suggested changes back to the repository. This will make it easier for collaborators to collaborate on this project with you as everyone will be following the same programming style guide.

You will need to ensure Github actions have write permissions for this to work:

https://github.com/mmcc-xx/WhosAtMyFeeder/settings/actions

mmcc-xx commented 1 year ago

Hi @bertybuttface - I'm finally getting around to the pull requests that were posted while I was away. Why did you close this one?

bertybuttface commented 1 year ago

The last two commits regarding relative directories are only really relevant for the home assistant addon, in fact merging them would break the app from working standalone (i.e. running not as a home assistant addon).

The rest of the commits are decent though, might be worth cherry picking some of it or I can do a new PR.

mmcc-xx commented 1 year ago

If you could do a new PR I'd appreciate it.