mmccoo / kicad_mmccoo

This is a repository to hold example and utility code for scripting within kicad (currently limited to pcbnew)
Apache License 2.0
106 stars 26 forks source link

Fixed filename dialog on svg2border and added svg2Outline item. #8

Closed TomWS1 closed 6 years ago

TomWS1 commented 6 years ago

The last update to svg2border added file and layer dialogs, which are great additions, however, the filename was never used in the two actions (still referenced the old hardcoded svg file). While I was updating, I decided that edge.cuts layer really needs an outline, not a filled polygon, so added the svg2outline action to the other two. The diff file is added below. svg2border.txt

mmccoo commented 6 years ago

thank you! I have fixed both issues

Also, svg parsing results with some duplicate endpoints. I haven't taken the time to find out why. So the plugin will just skip zero length segments.

Thank you for taking the time to report. Zero bugs reported means no ones using it which means why should I bother. I can take me months to reply to filed issues, but I try to get to them eventually.

Miles