search

mmcdermott / EventStreamGPT

Dataset and modelling infrastructure for modelling "event streams": sequences of continuous time, multivariate events with complex internal dependencies.
https://eventstreamml.readthedocs.io/en/latest/
MIT License
102 stars 16 forks source link

Add computation over future summary windows to flat reps #105

Closed mmcdermott closed 6 months ago

mmcdermott commented 6 months ago

This is useful when using flat features to compare/contrast populations (e.g., across clusters).

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

The recent updates focus on enhancing the data handling capabilities in dataset_polars.py. Key improvements include the introduction of the timedelta import for better time calculations, refined logic for total observations, and advanced data aggregation techniques tailored to various window sizes. These changes aim to optimize the observation frequency calculations and provide more precise data analysis tools.

Changes

File Path Summary of Changes
EventStream/.../dataset_polars.py Added timedelta import, refined observation frequency calculations, and introduced new aggregation functions for different window sizes. Adjusted data aggregation logic.
tests/test_e2e_runs.py Updated feature_selector in make_command function to include additional window sizes "-1h" and "-FULL" in the dictionary.
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between f84069cd79b8e0dc5dba78a6c5a29d1aa28f7f7f and 8da042a7ddca6f16b8bab744040c043b56d47a94.
Files selected for processing (1) * tests/test_e2e_runs.py (1 hunks)
Additional Context Used
Ruff (8)
tests/test_e2e_runs.py (8)
5-5: Module level import not at top of file --- 6-6: Module level import not at top of file --- 7-7: Module level import not at top of file --- 8-8: Module level import not at top of file --- 9-9: Module level import not at top of file --- 10-10: Module level import not at top of file --- 11-11: Module level import not at top of file --- 13-13: Module level import not at top of file
Additional comments not posted (1)
tests/test_e2e_runs.py (1)
`201-204`: The addition of new window sizes "-1h" and "-FULL" to the `feature_selector` dictionary aligns with the PR objectives and enhances the flexibility of feature selection based on different time windows.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.56%. Comparing base (2d00aec) to head (f84069c). Report is 1 commits behind head on dev.

:exclamation: Current head f84069c differs from pull request most recent head 8da042a. Consider uploading reports for the commit 8da042a to get more accurate results

Files Patch % Lines
EventStream/data/dataset_polars.py 66.66% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #105 +/- ## ========================================== - Coverage 86.60% 86.56% -0.05% ========================================== Files 29 29 Lines 6547 6556 +9 ========================================== + Hits 5670 5675 +5 - Misses 877 881 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.