mmcdermott / EventStreamGPT

Dataset and modelling infrastructure for modelling "event streams": sequences of continuous time, multivariate events with complex internal dependencies.
https://eventstreamml.readthedocs.io/en/latest/
MIT License
94 stars 15 forks source link

Test cases and (eventually) fixes for #114 #117

Open mmcdermott opened 1 week ago

mmcdermott commented 1 week ago

STILL IN PROGRESS. We just have failing test cases for now.

coderabbitai[bot] commented 1 week ago

Walkthrough

The updates primarily enhance the handling of subject IDs across various modules, ensuring type compatibility and refining filtering logic. Key changes involve the FT_task_baseline.py, dataset_polars.py, and dataset_base.py files, improving the robustness of data processing. Additionally, a new script build_flat_reps.py for building flat representation datasets is introduced, along with multiple adjustments and new tests in the testing files.

Changes

File(s) Change Summary
EventStream/baseline/FT_task_baseline.py Added overwrite_cache_filtered_task parameter, adjusted subject ID filtering logic using ESD.subject_id_dtype.
EventStream/data/dataset_polars.py Updated subject ID dtype handling, revised n_events_per_subject calculation, adjusted inclusion targets filtering, added debug logs.
EventStream/data/dataset_base.py Modified caching mechanism for reading and writing parameters, improved subject chunk processing for deep learning shard creation.
EventStream/data/pytorch_dataset.py Updated _seeded_getitem method to ensure consistent data types for subject IDs.
scripts/build_flat_reps.py New script introduced to build a flat representation dataset using a Hydra configuration file, including necessary imports and dataset processing steps.
tests/test_e2e_runs.py Added imports for json and polars, introduced _test_dataset_output method, modified setUp and build_dataset methods for handling and asserting Parquet dataset contents.
tests/data/test_pytorch_dataset.py Changed setUp method to convert a list of integers to strings in the shards dictionary construction.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Script as build_flat_reps.py
    participant Dataset as EventStream.data.dataset_polars.Dataset

    User ->> Script: Execute script with config file
    Script ->> Dataset: Load dataset
    Script ->> Dataset: Resolve cache parameters
    Script ->> Dataset: Cache flat representation
    Dataset ->> Script: Return success status
    Script ->> User: Process completed

[!TIP]

Early access features: enabled We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.06%. Comparing base (f84069c) to head (9f3ce52). Report is 39 commits behind head on dev.

:exclamation: Current head 9f3ce52 differs from pull request most recent head 5150e05

Please upload reports for the commit 5150e05 to get more accurate results.

Files Patch % Lines
EventStream/data/pytorch_dataset.py 37.50% 5 Missing :warning:
EventStream/baseline/FT_task_baseline.py 60.00% 2 Missing :warning:
EventStream/data/dataset_polars.py 91.30% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #117 +/- ## ========================================== - Coverage 86.56% 86.06% -0.50% ========================================== Files 29 29 Lines 6556 6387 -169 ========================================== - Hits 5675 5497 -178 - Misses 881 890 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.