mmcdermott / MEDS_transforms

A simple set of MEDS polars-based ETL and transformation functions
MIT License
19 stars 5 forks source link

Release 0.0.3 -- ensures MIMIC-IV ETL can be run without `rootutils` and that it works with unzipped files. #115

Closed mmcdermott closed 3 months ago

mmcdermott commented 3 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes enhance the functionality and flexibility of several scripts within the project. Notable updates include expanded spell-checking options, improved data loading processes, and the introduction of new transformation capabilities for reordering measurements. Configuration files have been refined to align with these updates, ensuring clarity and consistency. Overall, these modifications streamline workflows and enrich the project's capabilities.

Changes

Files/Paths Change Summary
.pre-commit-config.yaml Expanded codespell ignore words list to include "crate" alongside "ehr".
MIMIC-IV_Example/joint_script.sh Added optional argument do_unzip to enhance file processing flexibility.
MIMIC-IV_Example/pre_MEDS.py Removed load_raw_mimic_file, replaced with dynamic file reading using get_supported_fp, and improved error handling.
eICU_Example/pre_MEDS.py Removed rootutils import and initialization, simplifying directory management.
pyproject.toml Removed rootutils from dependencies; added support for MEDS_transform-reorder_measurements.
src/MEDS_transforms/... Various parameter renames (e.g., code_modifier_columns to code_modifiers), improved function signatures, and streamlined logic.
src/MEDS_transforms/configs/preprocess.yaml Renamed configuration parameter from code_modifier_columns to code_modifiers.
src/MEDS_transforms/configs/... Introduced reorder_measurements.yaml file to define measurement reordering rules.
src/MEDS_transforms/utils.py Added get_smallest_valid_uint_type function for determining optimal unsigned integer types.
tests/... Added tests for reorder_measurements functionality and enhanced utility functions for testing.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant JointScript
    participant PreMEDS
    participant Config
    participant Transform

    User->>JointScript: Run script with do_unzip argument
    JointScript->>PreMEDS: Process files based on configuration
    PreMEDS->>Config: Read dynamic file format
    Config->>Transform: Apply transformations
    Transform->>User: Return processed data

🐇 In a world of code and lines,
A rabbit hops through changing times.
With spells corrected, files in sync,
New paths appear, and stars now blink.
So let us cheer for every mod,
For coding's joy is truly broad! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.26027% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.48%. Comparing base (e1e6260) to head (9a5de23). Report is 415 commits behind head on main.

Files with missing lines Patch % Lines
src/MEDS_transforms/mapreduce/mapper.py 95.16% 3 Missing :warning:
...MEDS_transforms/transforms/reorder_measurements.py 97.56% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #115 +/- ## ========================================== + Coverage 92.20% 92.48% +0.28% ========================================== Files 12 24 +12 Lines 539 1664 +1125 ========================================== + Hits 497 1539 +1042 - Misses 42 125 +83 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.