search

mmcdermott / MEDS_transforms

A simple set of MEDS polars-based ETL and transformation functions
MIT License
20 stars 5 forks source link

Attend to the new "MEDS_DEATH" code #209

Closed rvandewater closed 3 weeks ago

rvandewater commented 1 month ago

@prockenschaub discovered that in the latest code extraction done by MEDS_transforms, the code for death is MEDS_DEATH (and not death). This should be changed in the event configs in order to not end up with only negative samples. E.g.,: https://github.com/Oufattole/meds-torch/blob/main/MIMICIV_TUTORIAL/configs/tasks/mortality/in_icu/first_24h.yaml. Perhaps it is possible to have some central repo for these tasks (not sure how practical though)?

justin13601 commented 1 month ago

Perhaps it is possible to have some central repo for these tasks (not sure how practical though)?

We've started compilling a central repo for some tasks at MEDS-DEV!

rvandewater commented 1 month ago

I was aware of this repo but was not sure if it was the most up-to-date task as I have tried to use many. We should probably remove the yaml's that are outdated/hosted in only one repo in that case.

mmcdermott commented 4 weeks ago

I think this is a great issue, but it seems to be possibly more relevant to other repos, not this. Is that accurate @rvandewater? If so, can we close it?

rvandewater commented 3 weeks ago

Agreed