search

mmcdermott / nested_ragged_tensors

Utilities for efficiently working with, saving, and loading, collections of connected nested ragged tensors in PyTorch
MIT License
7 stars 1 forks source link

_:hammer_and_wrench: Refactor suggestion_ #36

Open mmcdermott opened 1 week ago

mmcdermott commented 1 week ago 
          _:hammer_and_wrench: Refactor suggestion_

Use enumerate for Cleaner Looping

In _slice_single, replace manual index tracking with enumerate:

-    i = 0
-    for dim in sorted(squeeze_dims):
-        out = out.squeeze(dim - i)
-        i += 1
+    for i, dim in enumerate(sorted(squeeze_dims)):
+        out = out.squeeze(dim - i)

This change improves clarity and conciseness.

Committable suggestion was skipped due to low confidence.

🧰 Tools
🪛 Ruff
1261-1261: Use `enumerate()` for index variable `i` in `for` loop (SIM113)

_Originally posted by @coderabbitai[bot] in https://github.com/mmcdermott/nested_ragged_tensors/pull/35#discussion_r1796043644_