search

mmcdole / gofeed

Parse RSS, Atom and JSON feeds in Go
MIT License
2.59k stars 208 forks source link

Fix race in urlStack #171

Closed andrewgleave closed 3 years ago

andrewgleave commented 3 years ago

Fixes a race condition in urlStack by adding a sync.RWMutex

mmcdole commented 3 years ago

@andrewgleave I need to look at this again. I had thought that the data race was from actually having a shared urlStack in the first place.

Even with a mutex, won't it be possible for multiple concurrent feeds parsed to modify the state of urlStack?

andrewgleave commented 3 years ago

Yeah. It is a superficial change, sorry.

Closing.