Support for comments tag in feed Item

mmcdole / gofeed

Parse RSS, Atom and JSON feeds in Go

MIT License

2.56k stars 208 forks source link

Support for comments tag in feed Item #198

Closed piraces closed 1 year ago

piraces commented 1 year ago

Expected behavior

The gofeed.Item should have an entry for the <comments> tag, which its in the RSS 2 specification, in order to extract and parse that content.

Actual behavior

There is no actual way to extract the <comments> tag if available in the feed item.

Steps to reproduce the behavior

Example with https://stacker.news/rss:

Each item has a comment item and its not availiable in any entry of the feed.Item

Example of parsed item

mmcdole commented 1 year ago

@piraces thanks for this report. I'll fix this ASAP.

Unless you want to push an MR for the new field, and updates to rss/parser.go, rss/parser_test.go, parser.go, and the translator.go.

piraces commented 1 year ago

Thanks @mmcdole , nowadays am I little bit busy but I can attempt to do so 👍

piraces commented 1 year ago

Sorry for the confusion, this it's already implemented and I was wrong on the initial assumption... the rss/feed.go already has the comments mapping and the problem is on my side (since in atom feeds the is no such property). I will close the issue 👍