mmcdole / gofeed

Parse RSS, Atom and JSON feeds in Go
MIT License
2.56k stars 208 forks source link

Support URI field for Author in Atom Feed #200

Open imirzadeh opened 1 year ago

imirzadeh commented 1 year ago

Expected behavior

According to the specifications, author in Atom can have uri. This is useful for blog platforms where in the returned xml does not return html link to the webpage and instead returns author's profile/webpage. Here's an example

Actual behavior

The Person in gofeed has only name and email. But for Atom feeds, it needs uri as well.

mmcdole commented 1 year ago

@cristoper before I check on this, did your latest change address this? I briefly saw some handling of URI components in Atom, but wasn't sure if it was unrelated.

cristoper commented 1 year ago

No, this is unrelated.

It looks like atom.Person does have a URI field, but gofeed.Person does not.

mmcdole commented 1 year ago

Alright, I don't see an issue with us adding URL to gofeed.Person and map atom.Person.URI to it.