search

mmcdole / gofeed

Parse RSS, Atom and JSON feeds in Go
MIT License
2.56k stars 208 forks source link

Added fallback to atom icon when atom logo is missing #221

Closed spacecowboy closed 7 months ago

spacecowboy commented 7 months ago

First off, fantastic library! :clap: Great job.

While integrating it into Feeder (my Android feed reader) one of my unit tests failed. :disappointed:

This PR would make the test pass in my project. What do you think?

For reference, it is this assertion: https://github.com/spacecowboy/Feeder/blob/master/app/src/test/java/com/nononsenseapps/feeder/model/FeedParserTest.kt#L673

Which parses the file at: https://github.com/spacecowboy/Feeder/blob/master/app/src/test/resources/com/nononsenseapps/feeder/model/atom_cowboy.xml

mmcdole commented 7 months ago

Icon being a fallback for Feed.Image seems reasonable to me. Thanks for the contribution (and tests)!