Fixing waitgroups example

mmcgrana / gobyexample

Go by Example

https://gobyexample.com

7.16k stars 1.26k forks source link

Fixing waitgroups example #514

Closed OmarQunsul closed 6 months ago

OmarQunsul commented 6 months ago

Fixing waitgroups example.

Instead of printing

Worker 6 starting
Worker 6 starting
Worker 6 starting
Worker 6 starting
Worker 6 starting
Worker 6 done
Worker 6 done
Worker 6 done
Worker 6 done
Worker 6 done

It should print something like

Worker 5 starting
Worker 2 starting
Worker 4 starting
Worker 1 starting
Worker 3 starting
Worker 3 done
Worker 4 done
Worker 5 done
Worker 2 done
Worker 1 done

eliben commented 6 months ago

gobyexample assumes you use the latest version of Go, which is 1.22 right now

See https://go.dev/blog/loopvar-preview

OmarQunsul commented 6 months ago

gobyexample assumes you use the latest version of Go, which is 1.22 right now

See https://go.dev/blog/loopvar-preview

I just updated my local go version to 1.22.1 and indeed the old code works as expected. Thank you for the link