Closed adriancuadrado closed 4 months ago
I've noticed a file called arrays.hash. What is that for? Do I also have to update it?
I've noticed a file called arrays.hash. What is that for? Do I also have to update it?
You don't need to do it manually, you should run tools/build
which will also generate the public HTML for you. Did you do that for this PR?
@eliben
I've noticed a file called arrays.hash. What is that for? Do I also have to update it?
You don't need to do it manually, you should run
tools/build
which will also generate the public HTML for you. Did you do that for this PR?
I assumed these kind of things were made automatically by a CI/CD pipeline of some sort, as most people do. I'll run the script and commit the result, but I think you should consider creating a Github Action workflow or something instead.
EDIT: Hold on, you actually have that, but you use it to test the result and make sure I ran the script. Why though? Can't you just use the result of running that script automatically instead?
I assumed these kind of things were made automatically by a CI/CD pipeline of some sort, as most people do. I'll run the script and commit the result, but I think you should consider creating a Github Action workflow or something instead.
EDIT: Hold on, you actually have that, but you use it to test the result and make sure I ran the script. Why though? Can't you just use the result of running that script automatically instead?
The output in public
is currently committed to the repository, because the deployment process is a simple upload to a bucket. I want to keep the CI process simple - don't want it to change PRs/commits - it's only there to verify that everything was done correctly. Running tools/build
locally is important for testing the output anyway, so this isn't a problem in reality
You can learn more about this here: https://go.dev/blog/slices-intro#arrays