search

mmcgrana / gobyexample

Go by Example
https://gobyexample.com
7.16k stars 1.26k forks source link

Remove unreachable code from enums example #540

Closed BigJayToDaIzo closed 2 months ago

BigJayToDaIzo commented 2 months ago

After confirming I did not misunderstand how switch default and panic works, I realized there was some unreachable code in the example that may confuse new learners. Go LSP confirms.

image

BigJayToDaIzo commented 2 months ago

Thanks, this makes sense!

My pleasure! Thank YOU for the lovely refresher course after not having looked at any Go for a month! :grin:

BigJayToDaIzo commented 2 months ago

woops, fat fingered the mouse on that early close before merge. Apologies!

eliben commented 2 months ago

woops, fat fingered the mouse on that early close before merge. Apologies!

No worries, it's merged now.

Note that it may take a few days to show up on the published website, since the upload is done manually.