fatal bug somewhere between 3.22.1 + 3.23.0

mmckegg / mutant

Create observables and map them to DOM elements. Massively inspired by hyperscript and observ-*, but avoids GC thrashing.

MIT License

123 stars 11 forks source link

fatal bug somewhere between 3.22.1 + 3.23.0 #28

Open mixmix opened 5 years ago

mixmix commented 5 years ago

What it looks like : with 3.23.0 if you open a gathering editing form in Patchbay you get an empty form. If you do the same with 3.22.1 the form shows the gathering's current values.

I can confirm that the data is being fetched, and even successfully set in a Struct, but the h is just not noticing that change.

In trying to figure out this bug I've seen the same problem with computed - a value the computed should be watching is definitely being updated, but a debug inside the computed is never hit.

forces me to lock at earlier version

mixmix commented 5 years ago

Only things I can think which might be odd / relevant

this bug doesn't happen with npm linked patchbay-gatherings module, it only presents itself once you've published and installed the module
- means you have to test things by editing your node_modules installed version directly!
I'm doing some of this code around a modal which I'm hiding/ showing
- experience same problem when using css : visibility or display styles

I'm watching some of the observeables like this :

var isOpen = Value(false)

// somewhere else:
isOpen(state => {
// do stuff
})

mixmix commented 5 years ago

time spent so far ~4 hours (just as a reference so you know I'm not just posting without trying a bunch)

mixmix commented 5 years ago

cc @christianbundy (in case you bump into any mystery behaviour!) .... oh wait Patchwork is using a branch of mutant ... I wonder if it branches off before / after this bug!

christianbundy commented 5 years ago

Thank you!

mmckegg commented 5 years ago

@mixmix do you want to pair on this on Thursday? I have an office hour available at 10am.

mixmix commented 5 years ago

OFFICE HOUR, don't mind if I do! Yeah I'd love to @mmckegg , I'll put it in my calendar