mmckegg / web-audio-school

An intro to the Web Audio API by a series of self-guided workshops.

408 stars 40 forks source link

04. Add a high-pass filter #10

Closed randompast closed 7 years ago

randompast commented 8 years ago

As this is the first instance of having more than one node,

there should be some note about filter.connect(audioContext.destination) oscillator.connect(filter)

to prevent mistakes of this type: filter.connect(audioContext.destination) oscillator.connect(audioContext.destination)

mmckegg commented 8 years ago

Very good point. I have witnessed quite a few instances of people getting stuck on this problem.

I don't have time to work on this right now, but if anyone else wants to take a stab at it, I'll happily accept a pull request! :tractor:

newswim commented 7 years ago

+1 this tripped me up!

gmschroeder commented 7 years ago

16 adds explanatory comments. @mmckegg isn't sure if this is something to work through yourself or a bona fide issue.

I see the value in working through it yourself, but this feels like a 'gotcha' more than an excercise in reasoning. I'd be glad to write something or edit the existing pull request if I knew what/if would be accepted.

mmckegg commented 7 years ago

Hey @gmschroeder, @newswim and @joshuaalm! I've taken the feedback on board and ideas from #16 and added a section about how connect() works to this lesson.

Let me know if you think this addresses the problem sufficiently 😃

newswim commented 7 years ago

This helped a lot, thank you so much. :heart_eyes_cat:

mmckegg commented 7 years ago

Awesome 😄 I'll close this issue then!