search

mmckinst / puppet-lint-top_scope_facts-check

Find and convert from top scope facts to the trusted facts hash
Apache License 2.0
2 stars 4 forks source link

Don't detect namespaced variables as facts and fixup for puppet-lint >= 2.4 #11

Open alexjfisher opened 2 years ago

alexjfisher commented 2 years ago

Fixes #9 Fixed #10

MartyEwings commented 1 year ago

@mmckinst is this something we could get merged in and a release completed?

mmckinst commented 1 year ago

I'm trying to get permission from my employer to update it. If I'm unable to get their permission I will donate it to vox pupuli.

MartyEwings commented 1 year ago

thank you!

alexjfisher commented 1 year ago

@mmckinst, Hello there! If you decide to pass on the maintenance of this plugin to Vox Pupuli, please know that you will retain full copyright of all the code you have written, and the license will remain unchanged. We would also like to add you as a collaborator, so that you can continue to review and merge pull requests, if you're interested.

Our biggest issue with the plugin right now is that it requires puppet-lint < 3.0, which is preventing us from making progress. We don't want to give up on the plugin altogether, so our current plan is to include the plugin's check into a new voxpuli-puppet-lint-forks gem.

While we'd prefer not to do this, we won't make any changes until at least the end of this month. Also, this is something we can reverse later if you decide to maintain the gem yourself, or if you decide to migrate it to Vox Pupuli in the future.

Thank you for your time, and please let us know if you have any questions or concerns.

chelnak commented 1 year ago

@mmckinst Appreciate your response on this!

How would you feel about us (Puppet) bringing in your plugin in to puppet-lint as a default check?

mmckinst commented 1 year ago

@alexjfisher

I'm still going through the process to get approval from my employer. It will most likely come through but will be limited to minor patches for bug fixes or compatibility issues which should cover the maintenance needs of this plugin. It's not that I don't want to update it or maintain it, it is just my hands have been tied legally since 2020 and a new process has just been introduced recently. I should have an answer by the end of the month.

Regardless of that, I don't want to hold back the puppet community from making progress and I feel bad for not being able to update this for so long already.

You have my support to fork this to Vox Pupuli. I will update the README to point to the new home.

I'm not sure of how the fork will impact things already pulling this in their Gemfile. Will they just break once puppet-lint is incremented to 3.0 and they'll hopefully find the README pointing them to the new home and new rubygem name? Is there a way to make the transition smoother?

@chelnak

How would you feel about us (Puppet) bringing in your plugin in to puppet-lint as a default check?

I'm fine with this too.

ekohl commented 1 year ago

@mmckinst how would it practically go? I noticed it's all your code, except for https://github.com/mmckinst/puppet-lint-top_scope_facts-check/commit/61174be07f1e54855bd86eb83dd234c6e9c6bd04 so would it be sufficient for you and @seanmil to agree to relicense the code from Apache-2.0 (as this gem is) to MIT (as puppet-lint itself is)? Then import the code into puppet-lint.git?

seanmil commented 1 year ago

For my part, I'm fine with my contribution being relicensed as suggested. Thanks!

bastelfreak commented 1 year ago

https://github.com/puppetlabs/puppet-lint/pull/85 this PR now made it into puppet-lint