search

mmcknett / loggr

Time logging system
https://loggr-a3f89.web.app/
0 stars 0 forks source link

fix: Increase placeholder text contrast #36

Closed mmcknett closed 1 year ago

mmcknett commented 1 year ago

Fixes #33

Use the foreground color mentioned in the bug (#a6a6a6).

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 4ac5f29):

https://loggr-a3f89--pr36-placeholder-contrast-lma2ig5x.web.app

(expires Sat, 11 Feb 2023 06:37:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dcba139c17e47dff84a60c5907b98fbd13d724df

mmcknett commented 1 year ago

Excellent. I decided to go with the minimum accessible contrast so that there was a subtle difference in lightness between the default and input values. Maybe that's unnecessary, but it may also be moot later if I decide to replace it with a control that fully implements the combobox UX pattern. (See notes on #34 for why that might happen.)