printer: ensure compatibility with asmfmt

mmcloughlin commented 5 years ago

klauspost/asmfmt is the de facto standard for Go assembly formatting. It would be good to produce output that conforms to asmfmt.

I have a preference for avoiding non-Go dependencies (stdlib and sub-repos only). Therefore:

If it is possible to produce conforming output without actually depending on asmfmt explicitly, that would be preferred. This may actually be possible since (at the time of writing) many of the asmfmt rules simply wouldn't apply to avo output.
If the rules enforced by asmfmt are too complicated, then we can accept the additional dependency.

Either way, it would be good to have a check in CI to confirm that all generated files are formatted correctly. Something like find . -name '*.s' | xargs asmfmt -w and check the git repo is clean.

mmcloughlin commented 5 years ago

Fixed by 27cea3be8be210e33c6dbb00b0f9dff7d3bb46ae

mmcloughlin commented 5 years ago

Based on 3ca82be16cb95edc5d7c89ecc426c7eb0e233ba8 I think we have a mismatch with comments ahead of labels. But there seems to be a special case when there is a comment above and below a label? Needs investigation.

mmcloughlin commented 5 years ago

I think asmfmt sets indentation to 0 after terminal instructions. I'm not quite sure this is correct behavior. Filed klauspost/asmfmt#35 to discuss.

mmcloughlin / avo

printer: ensure compatibility with asmfmt #8