mmd123 / squid-cache-dynamic_refresh-list

list of dynamic_refresh patterns to use with squid3, I had a hard time finding things online, so I figured I'd make a collaborative github repo for just this purpose

8 stars 4 forks source link

Multiple Default Refresh Listed #11

Closed JonathanDLee24 closed 2 years ago

JonathanDLee24 commented 2 years ago

There are multiples of the default. 1661180437542-same 1661180472883-same2

I noticed that it should only use one of them. Maybe if it added #360 mins fresh 1 day store **#180 mins fresh 30 days store

30 mins fresh 1 day store**

and note above #only choose one

If you run all three of them, it slows the cache down.

1661180665750-same3 (Image: Reference Squid Website Why choose one)

JonathanDLee24 commented 2 years ago

https://forum.netgate.com/topic/172137/any-recommendations-this-custom-refresh_pattern/7?_=1661210555422

Ref: Request made by Netgate Forum Members to post issue here

mmd123 commented 2 years ago

huh....good catch, I completely missed that on my end admittedly. though it has been a while since I combed through these myself, yea, that's a good catch, and should not be there multiple times. given that in all honesty, ageekhere has been far more helpful on this than I have been, I will temporarily comment out the catchall section, awaiting his final suggested input/fix for this, but for now, I will go that route on my side. @ageekhere depending on your suggestion, feel absolutely free to change my fix for now.

ageekhere commented 2 years ago

https://github.com/mmd123/squid-cache-dynamic_refresh-list/pull/12

mmd123 commented 2 years ago

changes / edits commited, going to close this issue now that said, thank you once again @ageekhere and thank you for pointing this out @JonathanDLee24

JonathanDLee24 commented 2 years ago

No problem,

refresh_pattern . 0 20% 4320

Should also be the last item as it is the default cache all.

Get Outlook for Androidhttps://aka.ms/ghei36

From: Volt @.> Sent: Monday, August 22, 2022 5:52:16 PM To: mmd123/squid-cache-dynamic_refresh-list @.> Cc: JonathanDLee24 @.>; Mention @.> Subject: Re: [mmd123/squid-cache-dynamic_refresh-list] Multiple Default Refresh Listed (Issue #11)

changes / edits commited, going to close this issue now that said, thank you once again @ageekherehttps://github.com/ageekhere and thank you for pointing this out @JonathanDLee24https://github.com/JonathanDLee24

— Reply to this email directly, view it on GitHubhttps://github.com/mmd123/squid-cache-dynamic_refresh-list/issues/11#issuecomment-1223383499, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2VDGN5PZEJG3IENGR5R3U3V2QOEBANCNFSM57JNRKTA. You are receiving this because you were mentioned.Message ID: @.***>

ageekhere commented 2 years ago

@mmd123 @JonathanDLee24 Ah yes refresh_pattern . 0 20% 4320 should be last on the list, @mmd123 for now just move refresh_pattern . 0 20% 4320 to the bottom.

mmd123 commented 2 years ago

done