search

mmdevries / eiows

Other
78 stars 4 forks source link

Nodejs 20.12.0 issue #20

Closed thenitai closed 5 months ago

thenitai commented 5 months ago

Had it installed with the latest node 20.11.x but as of today the app doesn't start anymore as the module cannot be compiled anymore under 20.12.0.

mmdevries commented 5 months ago

Are you sure you recompiled the module for node 20.12.0? Can you send me the build_log.txt file then I will take a look. In my environment I don't see any build issues for node 20.12.0.

thenitai commented 5 months ago

Are you sure you recompiled the module for node 20.12.0? Can you send me the build_log.txt file then I will take a look. In my environment I don't see any build issues for node 20.12.0.

When I have 20.12.0 installed and include eiows I get this error message:

Compilation of µWebSockets has failed.Please install a supported C++17 compiler, git and/or update node and reinstall the module 'eiows'.

Going back to 20.11.x works. In both cases, I remove the whole node_modules folder, and reinstall everything. This happens in macOS and Ubuntu 22.04.

mmdevries commented 5 months ago

On the mac indeed the build failed. I have change the clang option on macOS and now it should work with eiows version 7.0.1. On ubuntu I don't see any build issues. Are you sure you are using gcc? And if so, which version are you using?

thenitai commented 5 months ago

Just tried it on Ubuntu again. Same message.

g++ --version
g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
mmdevries commented 5 months ago

Strange I use the same version without any issues. It would be really helpful if you could send me the build_log.txt file which is stored in the node_modules/eiows folder.

Op vr 29 mrt 2024 om 10:48 schreef Nitai @.***>:

Just tried it on Ubuntu again. Same message.

g++ --version g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0

— Reply to this email directly, view it on GitHub https://github.com/mmdevries/eiows/issues/20#issuecomment-2026962625, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADASVN6Z4NBA7UGM4O3XM2LY2U2GBAVCNFSM6AAAAABFLSZTUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWHE3DENRSGU . You are receiving this because you commented.Message ID: @.***>

thenitai commented 5 months ago

This is resolved with the latest release