mmdoogie / embed-stl

WordPress plugin adding Gutenberg block for embedding STL previews
Other
3 stars 0 forks source link

Extension do not work anymore #1

Open gauthierlerouzic opened 2 years ago

gauthierlerouzic commented 2 years ago

Hey ! I install your extension on my wordpress website, and the extension was working great just since few days. Look at this page : https://nozzler.fr/test-du-scanner-3d-creality-cr-scan-01/ I have a few box with your plugin, but now they are empty... Do you have any idea or suggestion ? Thank for your work

mmdoogie commented 2 years ago

Glad to see it being used!

Looking at the source on your webpage, the scripts are marked as "defer" to reduce the initial loading time, but since the plugin has inline script to load the models the deferred scripts are not available, causing the issue. This is a conflict with some type of page speed plugin that maybe was activated recently on your site. If you can narrow it down to which, I can look into improving compatibility with it, or maybe you can add an exception for this plugin's scripts in the meantime.

gauthierlerouzic commented 2 years ago

Of course i'm using it :D it's awesome !

So, I see what you mean about "defer" option. I'm using Jetpack Boost with "Defer Non-Essential JavaScript" option. I unchek the box. And I'm using also Async JavaScript plugin too. I select Embed STL to exception plugin, but not working, so I try to unactive the extension right now. Not working. This is weird... If you have any idea let me know

gauthierlerouzic commented 2 years ago

I can't found a solution :( I disable all the optimisation plugin, try to delete and reinstall the plugin... I add exclusion on the plugin to defer, but it don't work anymore :( Many you can ad an option to force JS running ?

gauthierlerouzic commented 2 years ago

UPDATE : It's working again. My solution was : disable the plugin "Content EGG". I don't really understand why this plugin block yours... If you found a solution I'm here :) Thanks again for your work, and have a nice day !

mmdoogie commented 2 years ago

Thanks for the input -- I'll take a look at that one and the others you were using and see if there's anything I can do to improve.

mmdoogie commented 2 years ago

I added that plugin to my test site and it was all still working. I wonder if that cleared out something cached that made it work. Does turning on Content Egg now cause it to fail again? It has a lot of settings, so it may be one very specific one, but I couldn't see anything that should interfere at first glance.

gauthierlerouzic commented 2 years ago

It's weird. Yes If I turn on Content EGG plugin, the Embed STL stop working. I don't know really why. When I found the bug, I try to shut down all my speed loading plugin. But embed STL still off. So I turn off each plugin one by one to see. And Content EGG was the one. After turn off Content EGG, I activate my speed loading plugin (Jetpack boost and Async JS) and it's working well.