pschil commented 2 years ago

May have gotten removed from CRAN because M1mac tests were failing. See https://cran-archive.r-project.org/web/checks/2022/2022-05-05_check_results_REndo.html

Rgui commented 2 years ago

But how come until now this test was not failing ? I re - submitted version 2.4.4 that you pushed. Should get back to us in 1 day or so.

On 6 May 2022, at 23:12, Patrik Schilter @.***> wrote:

May have gotten removed from CRAN because M1mac tests were failing. See https://cran-archive.r-project.org/web/checks/2022/2022-05-05_check_results_REndo.html https://cran-archive.r-project.org/web/checks/2022/2022-05-05_check_results_REndo.html You can view, comment on, or merge this pull request online at:

https://github.com/mmeierer/REndo/pull/69 https://github.com/mmeierer/REndo/pull/69 Commit Summary

0e4d5bf https://github.com/mmeierer/REndo/pull/69/commits/0e4d5bf5b164f6355a2de52bf1ae843e58212735 fix tests File Changes (1 file https://github.com/mmeierer/REndo/pull/69/files) M tests/testthat/test-correctness_latentIV.R https://github.com/mmeierer/REndo/pull/69/files#diff-18302910384d26a9b80f5225fa5563fba5007aa5c745cc6ed56f0a1ad0d1f9fd (35) Patch Links:

https://github.com/mmeierer/REndo/pull/69.patch https://github.com/mmeierer/REndo/pull/69.patch https://github.com/mmeierer/REndo/pull/69.diff https://github.com/mmeierer/REndo/pull/69.diff — Reply to this email directly, view it on GitHub https://github.com/mmeierer/REndo/pull/69, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB22X24MXFQ7XMBMDZDZT5LVIWDK7ANCNFSM5VJIMKBQ. You are receiving this because you are subscribed to this thread.

codecov[bot] commented 2 years ago

Codecov Report

Merging #69 (0e4d5bf) into development (6b0aa40) will not change coverage. The diff coverage is n/a.

@@             Coverage Diff              @@
##           development      #69   +/-   ##
============================================
  Coverage        97.40%   97.40%           
============================================
  Files               37       37           
  Lines             1657     1657           
============================================
  Hits              1614     1614           
  Misses              43       43

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

pschil commented 2 years ago

I don't understand why we got removed. The tests failing on M1mac are only listed as "Additional Issues". Also, the timing of the removal (5th May) coincides with the email (1st May) warning that regular checks on r-devel linux are failing because packages on which REndo depends could not be installed (there is nothing we can do about other packages not able to install and they disappeared the next day).

Unfortunately, our submission for 2.4.4 which went to CRAN now (after it was removed), does not contain the fixes for M1mac which are only on this branch.

pschil commented 2 years ago

according to Patrick this compiles and tests fine on his M1mac

mmeierer / REndo

Bugfix: latentIV tests fail on m1mac #69

Codecov Report