Closed RealJTG closed 8 years ago
Hi,
First off, thank you for the contribution! I do have a few small suggestions, let me know what you think.
-vvv
, or might be more complicated than -{option}{value}
, consider changing the configuration to look like this:{
"targets":[
{
"friendly":"altssh dev server available behind firewall",
"host":"user@dev.alt",
"options":[
"-p443",
"-vvv"
]
}
]
}
If we do this, I believe we can also use os.execvp(file, args)
to avoid unpacking the options (I haven't played around with this at all).
Otherwise, this looks like a very useful addition. I very recently had the need to add a target with a non-standard port, but I never wrote out the code for it, so this is pretty good timing for me.
Yep, sounds reasonable.
Done. Also moved command line options between "ssh" and "hostname" where they sould be (otherwise user may accidentally execute option without dash as command on remote host) and added indentation to newly created config file.
Nice! I'm going to test it out myself quickly, will comment back/merge afterwards.
Tagged in 0.0.2, release pushed to pypi + homebrew formula updated.
Thanks!
Fixes #1 Adds "options" configuration key
Will execute
ssh user@test.dev -p 443