mmick66 / CalendarView

An Easy to Use Calendar for iOS (Swift 5.0)
MIT License
598 stars 115 forks source link

Date Cell is missing when the end date is today #106

Open nassifbasheer opened 4 years ago

nassifbasheer commented 4 years ago

Hi,

You have created an excellent library.

I modified the style based on my requirement, set the end date as today, also updated the delegate method to allow dates between the start date and end date to be selectable. func calendar(_ calendar: CalendarView, canSelectDate date: Date) -> Bool

How ever if I tap any user selectable dates, some fields dates go missing. For example , if the start date is a month back and end date is today, if I tap on any date some dates go missing.

CalendarView-master-2.zip

mmick66 commented 4 years ago

Thank you for your comment. What do you mean that the dates go missing?

nassifbasheer commented 4 years ago

can you please run the project added as zip file.

nassifbasheer commented 4 years ago

If you see the image attached date 29 is missing.

Screenshot 2020-01-16 at 2 30 13 PM

mmick66 commented 4 years ago

I did check it. It must be a styling thing. It does not do it in the default project. Are you using the latest version?

nassifbasheer commented 4 years ago

Hi,

Yes, I downloaded this project last week. Hope that's the latest version.

On Thu, Jan 16, 2020, 6:43 PM Michael Michailidis notifications@github.com wrote:

I did check it. It must be a styling thing. It does not do it in the default project. Are you using the latest version?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mmick66/CalendarView/issues/106?email_source=notifications&email_token=ABGLTFOI7MVKCHPAXVIFHS3Q6BMPNA5CNFSM4KGNTR42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJEAH3A#issuecomment-575144940, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGLTFLQ3O33BCK3NIB4GVLQ6BMPNANCNFSM4KGNTR4Q .

mmick66 commented 4 years ago

It is definitely a styling thing. I will investigate some more if I have the time.

nassifbasheer commented 4 years ago

Hi Michael,

Did you get a chance to investigate.

On Thu, Jan 16, 2020 at 7:40 PM Michael Michailidis < notifications@github.com> wrote:

It is definitely a styling thing. I will investigate some more if I have the time.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mmick66/CalendarView/issues/106?email_source=notifications&email_token=ABGLTFPHBL3FGOHW2B3I6NDQ6BTGRA5CNFSM4KGNTR42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJEF6FQ#issuecomment-575168278, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGLTFLPRXBOY7DEFB73DXLQ6BTGRANCNFSM4KGNTR4Q .

-- Thanks, Nassif Basheer

mmick66 commented 4 years ago

I could not find anything so far. The project we have now works off the bat, but something with the styling that you add it makes the cell disappear.... I will try and look as to why, but for the moment, please add

override func viewDidAppear(_ animated: Bool) {

    // ... previous code ...

    self.calendarView.reloadData()
}

at the end of viewDidAppear. It worked on my machine.

nassifbasheer commented 4 years ago

ok, I shall check that. however this happens after selecting a date

On Tue, Jan 21, 2020 at 2:26 PM Michael Michailidis < notifications@github.com> wrote:

I could not find anything. The project we have now works off the bat, but something with the styling that you add it makes the cell disappear.... I will try and look as to why, but for the moment, please add

override func viewDidAppear(_ animated: Bool) { [previous code] self.calendarView.reloadData() }

at the end of viewDidAppear. It worked on my machine.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mmick66/CalendarView/issues/106?email_source=notifications&email_token=ABGLTFNJ2NQU4JWBM2PNLJTQ622FNA5CNFSM4KGNTR42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJO7BUY#issuecomment-576581843, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGLTFLB7BIUHWIDB3SER2TQ622FNANCNFSM4KGNTR4Q .

-- Thanks, Nassif Basheer

mmick66 commented 4 years ago

Try to force reload for the moment, until we find a better solution.

nassifbasheer commented 4 years ago

Hi,

So I downloaded the code from the master branch and re run the code , with no changes in style.

The start date is one month back from the current date. As of today it is Jan 22, 2020. How ever when I run the project, December 1st and Dec 14 is selectable and the selection goes random. if you see the image attached Dec 1 is highlighted and also after clicking Dec 1 , and hitting Dec 23 , Dec 16 is enabled. Simulator Screen Shot - iPhone Xʀ - 2020-01-22 at 15 31 52 Simulator Screen Shot - iPhone Xʀ - 2020-01-22 at 15 32 00

nassifbasheer commented 4 years ago

Hi,

Can you please verify the video attached. This is exact example project with no code change, Dec 1st and Dec 14 is selectable when the start date is one month back as on Jan 22, 2020.

On Tue, Jan 21, 2020 at 2:50 PM Michael Michailidis < notifications@github.com> wrote:

Try to force reload for the moment, until we find a better solution.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mmick66/CalendarView/issues/106?email_source=notifications&email_token=ABGLTFLOT7YKF6ON3I5CKILQ62457A5CNFSM4KGNTR42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJPBJZI#issuecomment-576591077, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGLTFKGIZWZ7FJSNPG3FCDQ62457ANCNFSM4KGNTR4Q .

-- Thanks, Nassif Basheer

kilirushi commented 4 years ago

I also had the same problem.It seems setColorOutOfRange is not right.