Closed patrickguevara closed 7 years ago
Hi Patrick,
Firstly - huge thank you for the PR.
Secondly - I'd rather do the following:
illuminate
-type packages to ^5.0
which should work just fine for all 5.0-5.4 versions;I think this approach would potentially create fewer issues for people who use older versions of illuminate
packages (and 5.1 is LTS, so I have to keep that in mind).
I have a branch ready for merging, let me know by tomorrow.
Even better! With what you're proposing you'd be able to sync major version numbers with the https://github.com/thephpleague/flysystem-vfs package (which has been as 1.0.2
for over a year).
I honestly forget there's an LTS that still needs supporting 😬
Great! In that case - I already merged my branch and tagged the stable. Packagist is updated as well. So simple composer update
will not break and keep the installed version as 0.0.3
. If you don't mind, updating the entry in your composer.json
to
{
...
"require-dev": {
...
"mmieluch/laravel-vfs-provider": "^1.0"
}
...
}
will install the current stable 1.0.0
.
Enjoy! And sorry about the wasted PR ;)
With Laravel 5.4 out and little to no effect on this package's compatibility, I suggest changing the
composer.json
from...to...
and tagging this version
v0.0.4
.If anyone needs 5.0-5.3 compatibility, they can use the
v0.0.3
release without issue.