search

mmig / libflac.js

FLAC encoder and decoder in JavaScript
Other
93 stars 22 forks source link

Fix Makefile #15

Closed raphj closed 4 years ago

raphj commented 4 years ago

Hello,

I needed to compile libflac.js. Here are the changes I needed to apply to the Makefile to compile with the latest version of emscripten on GNU/Linux.

I haven't tried if libflac.js as compiled with these changes works. More specifically, I had to remove BINARYEN_TRAP_MODE='clamp' , and I had to change the wildcard *.o to libFLAC-static.a. I don't know if it is correct.

raphj commented 4 years ago

This fixes https://github.com/mmig/libflac.js/issues/10

russaa commented 4 years ago

Thank you for your work! Could you verify that the compiled wasm versions do work?

I am a bit worried about the removal of BINARYEN_TRAP_MODE='clamp', since it can help avoiding most of possibly silent errors in the compiled wasm code. I vagely remember that it was necessary to change it from the default 'allow' when adding the wasm compilations.

raphj commented 4 years ago

Hello @russaa,

unfortunately, I cannot test this. I was trying to compile Jitsi Meet, which uses libflac.js for F-Droid. It turns out, the Android app does not use libflac.js so we ended up removing libflac.js from the compilation process altogether.

I have no experience with libflac. However, if you have a sample html/js test file, I can look at it :-)

Feel free to close without merging.

russaa commented 4 years ago

@raphj thanks for your work -- I will use it a base/starting point for future releases compiled with emscripten v1.39.x which now uses the LLVM toolchain by default (instead of fastcomp)