search

mmikeww / AHK-v2-script-converter

AHK v1 -> v2 script converter
https://autohotkey.com/boards/viewtopic.php?f=6&t=25100
The Unlicense
489 stars 38 forks source link

menu tray bugs #179

Closed mmikeww closed 3 weeks ago

mmikeww commented 1 month ago

from forum https://www.autohotkey.com/boards/viewtopic.php?p=573895&sid=a856ddeab374f28658a4e1d432887b4e#p573895

Banaanae commented 1 month ago

Icons were fixed in #126, but the fix isn't running, example one should be an easy fix

andymbody commented 3 weeks ago

Proposed fix...

Submitted PR... hopefully I did it correct... it's so confusing! lol

mmikeww commented 3 weeks ago

you can submit the PR and then we can test

typically the work flow is:

  1. you test on your local machine and try to get it as clean as possible before sharing
  2. you upload to branch on your personal repository
  3. you submit PR into main repository pointing to your branch
  4. people can review and test your PR code
  5. if suggestions/changes need to be made, you update your PR accordingly by updating your branch
  6. people retest your changes
  7. if looks good, PR is accepted and merged into main repository

remember to add new tests in your PR showing what your changes accomplish

andymbody commented 3 weeks ago

you can submit the PR and then we can test

Ok... will do... thanks...

Banaanae commented 3 weeks ago

Fixed in #182

andymbody commented 3 weeks ago

The OP posted an update after testing this fix, and it was not fixed. I made an adjustment to fix it. Does this require a new issue to be created, or can this one be reopened? I am almost ready to post the updated fix, but wanted to find out how to handle this.

mmikeww commented 3 weeks ago

You can just create a new PR directly and mention this issue

On Sun, Jun 9, 2024, 12:09 AM andymbody @.***> wrote:

The OP posted an update after testing this fix, and it was not fixed. I made an adjustment to fix it. Does this require a new issue to be created, or can this one be reopened? I am almost ready to post the updated fix, but wanted to find out how to handle this.

— Reply to this email directly, view it on GitHub https://github.com/mmikeww/AHK-v2-script-converter/issues/179#issuecomment-2156306769, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOQBDHQGTMFNREYIMXWBDDZGPIPNAVCNFSM6AAAAABIVUDNU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGMYDMNZWHE . You are receiving this because you authored the thread.Message ID: @.***>