search

mmikeww / AHK-v2-script-converter

AHK v1 -> v2 script converter
https://autohotkey.com/boards/viewtopic.php?f=6&t=25100
The Unlicense
489 stars 38 forks source link

fix_Yunit_test_file #181

Closed andymbody closed 1 month ago

andymbody commented 1 month ago

Fixed IfBetweenAlphabetically() within Test.ahk (line 4818 - changed = to <=, >=).

This also changed LF to CRLF for all lines within file

Banaanae commented 1 month ago

Looks good, but not sure if this is needed, AFAIK the Tests.ahk has been replaced with the much easier to maintain, Tests folder (the one accessed with Testmode on QuickConvertor), with all of the Tests.ahk tests being copied over to the Yunit_tests folder.

If I'm correct with the fact that it's not being used it might be an idea to delete the file to avoid confusion? Otherwise we can merge @mmikeww Do you know if Tests.ahk is still being used (and hence worth maintaining)

andymbody commented 1 month ago

Is there by chance a "priority list" or "desired fixes" that should be focused on? I have looked at the Issues list and am trying to concentrate on low hanging fruit while I get more familiar with github website, commands, process (currently considerable effort due to learning curve with github related activities). But, perhaps this is the wrong approach? "That's not needed", implies that something else should receive focus instead? Where can I find this specific list? So that efforts are not in vane going forward (for all of us)? Thanks...

mmikeww commented 1 month ago

When I first started writing test cases for the converter, I used yunit module and put all the tests in that large file. As far as I know, those tests were not duplicated when the new test folder format was migrated to, so I believe some of those tests are still useful to keep and run

On Mon, Jun 3, 2024, 8:05 AM andymbody @.***> wrote:

Is there by chance a "priority list" or "desired fixes" that should be focused on? I have looked at the Issues list and am trying to concentrate on low hanging fruit while I get more familiar with github website, commands, process (currently considerable effort due to learning curve with github related activities). But, perhaps this is the wrong approach? "That's not needed", implies that something else should receive focus instead? Where can I find this specific list? So that efforts are not in vane going forward (for all of us)? Thanks...

— Reply to this email directly, view it on GitHub https://github.com/mmikeww/AHK-v2-script-converter/pull/181#issuecomment-2145023030, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOQBDBTNKJRDCG4RCOQBJTZFRLYFAVCNFSM6AAAAABIVZRBCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGAZDGMBTGA . You are receiving this because you were mentioned.Message ID: @.***>