search

mmikeww / AHK-v2-script-converter

AHK v1 -> v2 script converter
https://autohotkey.com/boards/viewtopic.php?f=6&t=25100
The Unlicense
538 stars 42 forks source link

Fix Ptr property #205

Closed Banaanae closed 2 months ago

Banaanae commented 3 months ago

Ran into problems when converting this This PR should fix it, but I'll leave it here for people to confirm if this is the correct conversion, and if any problems were introduced

andymbody commented 3 months ago

This is adding support of buffer object?

Banaanae commented 3 months ago

Yes-ish, buffer was already converted, put when you use a buffer in a pointer I'm pretty sure you need to add .Ptr, same with first parameter of StrGet (and maybe StrPut?)

andymbody commented 3 months ago

I looked it over, and it looks fine to me...

Just my opinion... I would say if it works, should be acceptable. I might have code in my library to test it on, but would take too long to find it. If an issue arises in the future, it can be addressed then.

Banaanae commented 2 months ago

It appears all instances of &BufferObj need to be replaced with BufferObj.Ptr no matter location This will probably be closed and replaced with new fix