mmikeww / AHK-v2-script-converter

AHK v1 -> v2 script converter
https://autohotkey.com/boards/viewtopic.php?f=6&t=25100
The Unlicense
581 stars 44 forks source link

Fix Typos #223

Closed fade2gray closed 4 months ago

fade2gray commented 4 months ago

Fix typos after adding opening and closing braces - { and } are braces, not brackets 😜.

andymbody commented 4 months ago

There are a whole lot of changes here that will undo recent merges (over the past few days/weeks). Were your changes made using the latest master?

fade2gray commented 4 months ago

Good catch. I forked the master and created a local clone, but I edited the file from the downloaded version from the forum link, copied it over the file in my clone and pushed it back to my fork.

I guess you can just drop the PR your end, and I'll submit another being more careful this time?

Banaanae commented 4 months ago

These changes are nice to have (anything to make script more clear), if you could resubmit with up-to-date changes I'll merge

andymbody commented 4 months ago

I guess while you're at it, might as well remove some commented out code that was left "just in case". I do like the date comments tho, cause I forget what was edited and why without peeking into the project history. I personally think those comments provide benefit while browsing and editing the code. Is it helpful to any of you, or do you consider it clutter?

Banaanae commented 4 months ago

I'm fine with date comments, and yes most of the "just in case" code really isn't necessary like here git stores all the changes ever made so if we did need to go make it is stored there

GitHub allows maintainers to edit PR's so I should be able to clean up this just in case code and have fade2gray's fixes all in one commit

andymbody commented 4 months ago

I'm fine with date comments, and yes most of the "just in case" code really isn't necessary like here

Ok... I will try to do a better job cleaning up my messes. Sorry about that.

Banaanae commented 4 months ago

Ok... I will try to do a better job cleaning up my messes. Sorry about that.

No worries, it was all commented out so it doesn't affect end user experience

andymbody commented 4 months ago

if @fade2gray doesn't clean up my mess with this commit, I will do it as part of my next submission.