mmikhasenko / ThreeBodyDecaysIO.jl

0 stars 0 forks source link

Lb2pkg #1

Closed IlyaSegal closed 2 months ago

IlyaSegal commented 4 months ago

I prepared a JSON file and a Julia test file for reading the LbpKg model. For now, the test failed, throwing an error: ERROR: DomainError with -Inf. Do you have any suggestions on what can be the reason? Also, for now, I have excluded non-resonant poles since it is not possible to leave the "parametrization" field empty. But, probably, I can try to add a function for the non-resonant poles (it is simply an exponent) based on the example of Breit-Wigner. I inserted all the resonances with the L-S recoupling type. Am I right? Am I missing something else, what can cause this divergence?

Closes #2

mmikhasenko commented 4 months ago

Also, for now, I have excluded non-resonant poles since it is not possible to leave the "parametrization" field empty.

For now, additional lineshapes are living in src/HadronicLineshapesIO.jl. E.g. you find there an implementation of BreitWignerWidthExp: one needs three blocks: structure, call, and a constructor of wrapper for parsing.

mmikhasenko commented 4 months ago

For now, the test failed, throwing an error: ERROR: DomainError with -Inf. Do you have any suggestions on what can be the reason?

It was my issue, I've broken the test on Friday. Should be fixed now

mmikhasenko commented 4 months ago

I inserted all the resonances with the L-S recoupling type.

I think that is right.

mmikhasenko commented 4 months ago

well done!! 👍

It can be done by matching the value of the unpolarized_intensity for the build model against the reference in a single kinematic point.

A simple way to call unpolarized_intensity on a decay chain is unpolarized_intensity(model[3:3], sigma_test)

codecov[bot] commented 4 months ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

mmikhasenko commented 4 months ago

@IlyaSegal have a look to minor updates of json file 8101c1059ff2dabbd467b9984de452657ae2f86a 1d583a4419a2526b8a26b7d57656a677bc7ca917

I've added validation step to tests. It passes now for Lc2ppiK, and fails for your decay. The value for the cross check is made up. To put correct value, evaluate the notebook in https://gitlab.cern.ch/mimikhas/Lb2pKg.jl at the appropriate point

mmikhasenko commented 2 months ago

Solved on https://github.com/RUB-EP1/amplitude-serialization/pull/34 and https://github.com/RUB-EP1/amplitude-serialization/pull/39