search

mmikkel / Retcon-Craft

A collection of powerful Twig filters for modifying HTML
MIT License
80 stars 9 forks source link

Errors on image transforms #66

Closed mmikkel closed 9 months ago

mmikkel commented 10 months ago

Hi, we have a project with Imager and Retcon plugins. We recently upgraded the Retcon plugin to the version 2.7.0 and found that it's giving errors on image transforms:

Screenshot 2023-10-27 at 5 03 05 PM

Additional info

Originally posted by @anita-chouhan in https://github.com/mmikkel/Retcon-Craft/issues/38#issuecomment-1784765817

mmikkel commented 10 months ago

Hi @anita-chouhan,

Thanks for reporting.

This looks like a compatibility issue with Imager, as the safeFileFormats config setting was only added in Imager X (the successor to Imager, which is discontinued). I'll get that fixed as soon as I have the time – in the interim you might consider to

Also: It's not going to fix this specific issue – but if you choose to not downgrade Retcon, I highly recommend upgrading it to the latest release (2.7.4). There were a few regression errors introduced in 2.7.0 that have been fixed in subsequent releases.

anita-chouhan commented 10 months ago

Thank you for the suggestions. Upgrading to version 2.7.4 worked.

mmikkel commented 10 months ago

Hi @anita-chouhan, thanks for the follow-up. To be clear, are you saying that upgrading to Retcon 2.7.4 fixed the "Getting unknown property" exception you were getting before? Are you still running Imager 2.x?

anita-chouhan commented 10 months ago

Hello @mmikkel, sorry for the delayed response. We are still running Imager 2.4.0 and Retcon 2.7.4, and it's working fine.

mmikkel commented 9 months ago

I was able to reproduce the issue using Craft 3.9.5 and Imager 2.4.0, and a fix has been implemented for the next Retcon release.

mmikkel commented 9 months ago

Retcon v. 2.7.5 is out now with that fix.