mmiller42 / html-webpack-externals-plugin

Webpack plugin that works alongside html-webpack-plugin to use pre-packaged vendor bundles.
MIT License
99 stars 16 forks source link

Unmet dependency warning on installed package. #39

Open Paksssssss opened 6 years ago

Paksssssss commented 6 years ago

npm WARN html-webpack-externals-plugin@3.8.0 requires a peer of html-webpack-plugin@^2.0.0 but none was installed. is shown as an error everytime i run a command on npm. but then I do have an html-webpack-plugin package installed in my project.

my dependencies being:

"devDependencies": {
    "autoprefixer": "^8.6.3",
    "babel-core": "^6.26.3",
    "babel-loader": "^7.1.4",
    "babel-plugin-transform-class-properties": "^6.24.1",
    "babel-preset-env": "^1.7.0",
    "babel-preset-react": "^6.24.1",
    "bootstrap": "^4.1.1",
    "css-loader": "^0.28.11",
    "extract-text-webpack-plugin": "^4.0.0-beta.0",
    "html-webpack-externals-plugin": "^3.8.0",
    "html-webpack-plugin": "^3.2.0",
    "jquery": "^3.3.1",
    "node-sass": "^4.9.0",
    "optimize-css-assets-webpack-plugin": "^4.0.2",
    "popper": "^1.0.1",
    "postcss-loader": "^2.1.5",
    "sass-loader": "^7.0.3",
    "style-loader": "^0.21.0",
    "uglifyjs-webpack-plugin": "^1.2.6",
    "webpack": "^4.12.1",
    "webpack-cli": "^3.0.8",
    "webpack-dev-server": "^3.1.4",
    "webpack-merge": "^4.1.3"
  },
  "dependencies": {
    "@material/top-app-bar": "^0.36.1",
    "classnames": "^2.2.6",
    "gentelella": "^1.4.0",
    "history": "^4.7.2",
    "prop-types": "^15.6.2",
    "react": "^16.4.1",
    "react-dom": "^16.4.1",
    "react-router": "^4.3.1"
  }
mmiller42 commented 6 years ago

The peer dependency is for 2.x. I haven’t verified this plugin’s compatibility with 3.x.

nicholi commented 6 years ago

Simple testing seems to suggest there shouldn't be any breakage. I updated with my own fork to 3.x and it seems to still do the replacements for my scenarios.

WPaczula commented 5 years ago

Are there any plans for changing this peer dependency to 3.x? 🤔