mmiron-HC / WST-RSAMS

0 stars 0 forks source link

Subscribe: English error message appears in French page #106

Closed XiuJuanXia closed 2 years ago

XiuJuanXia commented 3 years ago

URL: https://hcdev.openplus.ca/fr/form/subscribe User Agent: Chrome Language: French

Issue Description: In French page, if leave any required field empty and activate the “Soumettre” button, English error message appears. image image image image

Steps to reproduce:

  1. Navigate through the forms and leave the forms empty
  2. Activate the "Soumettre" button
  3. English error message appears.
  4. Try to leave three different required fields empty and English error message always appears.

Expected results: In French page, error message should be translated into French.

echouin commented 3 years ago

@XiuJuanXia This is related to there being no error messages (similar to #105).

The reason the error message is in english is because it is the browser default message. The browser will use whatever default language is being used by the browser/OS.

Suggest Close?

XiuJuanXia commented 3 years ago

@echouin, tested in Chrome and Firefox, the three fields that have red asterisk * at the end are read "required" by screen readers. And also if checking the source code, required="required" for the input fields. In this case, if we leave the three fields empty and submit the form, proper error message should be triggered in proper language.

echouin commented 3 years ago

From OP: the reason for the alerts in the wrong language has to do with the client browser/OS config, not Drupal. There is a related issue being worked on here #105 , suggest that this one be closed in favor of 105 (which should solve both issues).

mmiron-HC commented 3 years ago

@echouin we do not close issues until the item has passed testing.

echouin commented 3 years ago

@mmiron-HC This is a Drupal WxT issue. OP unable to fix at this time.

davidgotlieb commented 2 years ago

Should be resolved with the fix that was implemented for 105

hydegeoff commented 2 years ago

this issues were resolved. Issue closed.